Skip to content

fix(shard): count -f as forcing a rebuild - #52

Merged
HaoZeke merged 2 commits into
mainfrom
fix/short-force
Nov 16, 2026
Merged

HaoZeke merged 2 commits into
mainfrom
fix/short-force

Conversation

@HaoZeke

@HaoZeke HaoZeke commented Nov 16, 2026

Copy link
Copy Markdown
Collaborator

-f is EasyBuild's short form of --force, but parse_lines counted only --rebuild and --force as forcing a line. A build list that rebuilds an installed CMake with -f and then builds Szip got two shards, so Szip could build while eb -f rebuilt CMake under it. With --force the same list plans one shard with CMake first.

parse_lines now treats -f like --force. The first commit adds the failing tests (parse flags and a stack shard count), and the second makes them pass. The stack shard reference and llms-full.txt name -f.

-f is EasyBuild's short form of --force, and shard_sources already
takes it as the one short option it models, but parse_lines counts only
--rebuild and --force as forcing a line. A build list that rebuilds
installed CMake with -f and then builds Szip, which needs CMake, gets
two shards: the CMake line builds nothing and weighs 0, and Szip lands
in another shard that can build while eb -f rebuilds CMake under it.
With --force the plan is one shard with CMake first.

Both tests fail: parse_lines gives [true, true, false, false] for
--rebuild, --force, -f and --hooks=-f, and stack shard prints
shards=2 for the -f list.
parse_lines now takes -f, EasyBuild's short form of --force, as it takes
--force and --rebuild: the line's own module counts as not installed.
With -f uncounted, an installed module the line rebuilds was left out of
every closure, so it weighed nothing, the line it belongs to was planned
as building nothing, and a line that needs the module could go to
another shard and build while eb -f rebuilt it.

The stack shard reference names -f, and llms-full.txt follows it.
@HaoZeke
HaoZeke merged commit e6e74e3 into main Nov 16, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant